Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
Martin Gräßlin
mgraesslin at kde.org
Tue Nov 17 07:21:37 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88456
-----------------------------------------------------------
should the file be added to ksnapshot?
- Martin Gräßlin
On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 6:06 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and David Edmundson.
>
>
> Repository: khotkeys
>
>
> Description
> -------
>
> After moving KSnapshot to Extragear I've modified it to install its own khotkeys file (which it does correctly). Spectacle already installs its own KHotkeys file, so there's no reason anymore for KHotkeys to include its own PrintScreen hotkey file.
>
> I'll push out a special release of KSnapshot for distributions to use once the Plasma 5.5 version of KHotkeys is pushed out, so printscreen functionality won't be broken on the desktop (assuming, that is, distros push out the updates together).
>
>
> Diffs
> -----
>
> data/CMakeLists.txt f3bcb57
> data/printscreen.khotkeys e583311
>
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
>
>
> Testing
> -------
>
> Doesn't install the printscreen.khotkeys file anymore
>
>
> Thanks,
>
> Boudhayan Gupta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151117/c7c49a82/attachment-0001.html>
More information about the Plasma-devel
mailing list