Review Request 126063: [DragArea] Support specifying delegateImage as QString

Kai Uwe Broulik kde at privat.broulik.de
Mon Nov 16 20:13:14 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126063/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 8:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 1c2e6e5810b1861eee6587c66e2372216ddbcbb3 by Kai Uwe Broulik to branch master.


Repository: kdeclarative


Description
-------

QML doesn't know QIcon or QImage, so when doing stuff purely from QML we should be able to set a string and have it get the QIcon::fromTheme for us


Diffs
-----

  src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 

Diff: https://git.reviewboard.kde.org/r/126063/diff/


Testing
-------

Works

Still get proper delegate image in Widget Explorer and the breakage in Kickoff seems unrelated (Kicker backend switch?)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/9485fa32/attachment.html>


More information about the Plasma-devel mailing list