Review Request 126063: [DragArea] Support specifying delegateImage as QString

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126063/#review88367
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 14, 2015, 4:47 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126063/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 4:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> QML doesn't know QIcon or QImage, so when doing stuff purely from QML we should be able to set a string and have it get the QIcon::fromTheme for us
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 
> 
> Diff: https://git.reviewboard.kde.org/r/126063/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> Still get proper delegate image in Widget Explorer and the breakage in Kickoff seems unrelated (Kicker backend switch?)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151114/424829ef/attachment.html>