Review Request 125973: Remove completely duplicated function

Sat Nov 14 22:52:51 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125973/#review88365
-----------------------------------------------------------

On some items (clipboard widget, battery, kde connect, doesn't matter if entry hidden or shown) I also get panel options in the context menu whereas on the rest (plasma-pa, ktp-contact-list, plasma-nm, ...) I only get systray options.

If that's unrelated to this patch, or you can fix it :), ship it.

- Kai Uwe Broulik

On Nov. 13, 2015, 12:19 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125973/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 12:19 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove almost completely duplicated function.
> One was used for right clicking on expanded items, the other for full compact items.
> 
> A missing action for expanded items is added so the two menus are now consistent.
> 
> Global co-ordinates are used as args for menus everywhere so we can share the mapping code SNIs currently use.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/host.h db6fc567666281c8b2fe81eab085ae4b950bf07d 
>   applets/systemtray/package/contents/ui/PlasmoidItem.qml c4f8ccb994ab605121de05ef6a966d2a565f171b 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml a53be6cb0d9fae14e055a6d1381ad11fee0a236e 
>   applets/systemtray/plugin/host.cpp 61e87050826a28409e44c8dac5baebe12e59bf63 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 84d2baf4da0ef6d0381dfc79fa374b5c54cf2189 
> 
> Diff: https://git.reviewboard.kde.org/r/125973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151114/8b634e94/attachment-0001.html>