Review Request 125973: Remove completely duplicated function

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125973/
-----------------------------------------------------------

(Updated Nov. 13, 2015, 12:19 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description (updated)
-------

Remove almost completely duplicated function.
One was used for right clicking on expanded items, the other for full compact items.

A missing action for expanded items is added so the two menus are now consistent.

Global co-ordinates are used as args for menus everywhere so we can share the mapping code SNIs currently use.


Diffs (updated)
-----

  applets/systemtray/plugin/host.h db6fc567666281c8b2fe81eab085ae4b950bf07d 
  applets/systemtray/package/contents/ui/PlasmoidItem.qml c4f8ccb994ab605121de05ef6a966d2a565f171b 
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml a53be6cb0d9fae14e055a6d1381ad11fee0a236e 
  applets/systemtray/plugin/host.cpp 61e87050826a28409e44c8dac5baebe12e59bf63 
  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 84d2baf4da0ef6d0381dfc79fa374b5c54cf2189 

Diff: https://git.reviewboard.kde.org/r/125973/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151113/78ebc29a/attachment.html>