Review Request 126060: Fix krunner crash when open "/"

Xuetian Weng wengxt at gmail.com
Sat Nov 14 00:40:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126060/
-----------------------------------------------------------

(Updated Nov. 14, 2015, 12:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Sebastian Kügler.


Changes
-------

Submitted with commit 0ab0823d8cd192f67a431174fa02b8975adc8987 by Weng Xuetian to branch master.


Bugs: 355290
    https://bugs.kde.org/show_bug.cgi?id=355290


Repository: plasma-workspace


Description
-------

Code crashes when calling dirNames.last(), since dirNames itself is empty when path is "/".

Add a condition to check if dirNames is empty and return right away.


Diffs
-----

  runners/locations/locationrunner.cpp cc12965 

Diff: https://git.reviewboard.kde.org/r/126060/diff/


Testing
-------

No more crash.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151114/54d56c3a/attachment.html>


More information about the Plasma-devel mailing list