Review Request 126060: Fix krunner crash when open "/"

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126060/#review88341
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 13, 2015, 10:12 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126060/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 355290
>     https://bugs.kde.org/show_bug.cgi?id=355290
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Code crashes when calling dirNames.last(), since dirNames itself is empty when path is "/".
> 
> Add a condition to check if dirNames is empty and return right away.
> 
> 
> Diffs
> -----
> 
>   runners/locations/locationrunner.cpp cc12965 
> 
> Diff: https://git.reviewboard.kde.org/r/126060/diff/
> 
> 
> Testing
> -------
> 
> No more crash.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151113/2397302d/attachment.html>