Review Request 125993: Implemented lastfmimagefetcher as a Plugin

[Ashish Bansal]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88301
-----------------------------------------------------------



libs/mediacenter/lastfmimagefetcher.cpp (line 46)
<https://git.reviewboard.kde.org/r/125993/#comment60554>

    Use latest Qt5 Signal/Slot signal syntax.



libs/mediacenter/lastfmimagefetcher.cpp (line 47)
<https://git.reviewboard.kde.org/r/125993/#comment60555>

    This statement seems to be redundant. If no one outside this class listens to this signal, then just remove it, or modify it and make PmcImageCache listen to it.



libs/mediacenter/pmcimagecache.cpp (line 100)
<https://git.reviewboard.kde.org/r/125993/#comment60556>

    As this slot is just emitting another signal, you should remove it and emit signal directly in connect function.


- Ashish Bansal


On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 4:23 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList
> 
> To update this info, the signal imageFetched is absorbed by imageFetchedFromLastFm in PmcImageCache.
> Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is emitted which is then absorbed by signalUpdate in PmcMetaDataModel
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcimagecache.h 6399461 
>   libs/mediacenter/pmcimagecache.cpp fcfe2a8 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> -------
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151112/9813968f/attachment.html>