Review Request 125978: [TabBarLayout] Layout sooner

Kai Uwe Broulik kde at privat.broulik.de
Sat Nov 7 12:17:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125978/
-----------------------------------------------------------

(Updated Nov. 7, 2015, 12:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 606c7f651d668349da79313806d5ecefbc6ed221 by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

Layout after 10ms rather than 150ms. Still long enough so we don't layout multiple times (it layouts twice in a row but did that before too)


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 6bc6fc9 

Diff: https://git.reviewboard.kde.org/r/125978/diff/


Testing
-------

Fixes the few frames after plasmashell startup where the Kickoff buttons are cramped together. I didn't notice a performance penalty while resizing or navigating.

(For some reason the layout's height changes when Kickoff expands/collapses, needlessly causing a re-layout but I couldn't figure out why that is)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151107/67faadb8/attachment.html>


More information about the Plasma-devel mailing list