Review Request 125978: [TabBarLayout] Layout sooner

Marco Martin notmart at gmail.com
Fri Nov 6 21:57:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125978/#review88110
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Nov. 6, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125978/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Layout after 10ms rather than 150ms. Still long enough so we don't layout multiple times (it layouts twice in a row but did that before too)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 6bc6fc9 
> 
> Diff: https://git.reviewboard.kde.org/r/125978/diff/
> 
> 
> Testing
> -------
> 
> Fixes the few frames after plasmashell startup where the Kickoff buttons are cramped together. I didn't notice a performance penalty while resizing or navigating.
> 
> (For some reason the layout's height changes when Kickoff expands/collapses, needlessly causing a re-layout but I couldn't figure out why that is)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151106/b90e1fda/attachment-0001.html>


More information about the Plasma-devel mailing list