Review Request 125957: kcm_formats: Fix sorting order and formatting in combo boxes

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125957/
-----------------------------------------------------------

(Updated Nov. 5, 2015, 5:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 4e033cdabfb876d75d5a8e08c74259559f9e38be by Jonathan Marten to branch master.


Bugs: 354895
    https://bugs.kde.org/show_bug.cgi?id=354895


Repository: plasma-desktop


Description
-------

See the referenced bug.  The country lists in the dropdown combo boxes are not sorted alphabetically, but countries without an associated language come first and have a spurious hyphen and space.

This patch fixes the comparison function countryLessThan() to fall back to the country name if there is no native country name, as happens at the top of KCMFormats::addLocaleToCombo().  It also ensures that the "Default (C)" locale appears at the top of the list so that it does not get buried way down the list.


Diffs
-----

  kcms/formats/kcmformats.cpp c1f6dd4 

Diff: https://git.reviewboard.kde.org/r/125957/diff/


Testing
-------

Built plasma-desktop/kcms/formats with this change, checked appearance and operation of 'kcmshell5 formats'.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151105/de41f0e9/attachment-0001.html>