Review Request 125957: kcm_formats: Fix sorting order and formatting in combo boxes

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125957/#review88051
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 5, 2015, 1:51 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125957/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 1:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 354895
>     https://bugs.kde.org/show_bug.cgi?id=354895
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> See the referenced bug.  The country lists in the dropdown combo boxes are not sorted alphabetically, but countries without an associated language come first and have a spurious hyphen and space.
> 
> This patch fixes the comparison function countryLessThan() to fall back to the country name if there is no native country name, as happens at the top of KCMFormats::addLocaleToCombo().  It also ensures that the "Default (C)" locale appears at the top of the list so that it does not get buried way down the list.
> 
> 
> Diffs
> -----
> 
>   kcms/formats/kcmformats.cpp c1f6dd4 
> 
> Diff: https://git.reviewboard.kde.org/r/125957/diff/
> 
> 
> Testing
> -------
> 
> Built plasma-desktop/kcms/formats with this change, checked appearance and operation of 'kcmshell5 formats'.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151105/925ed301/attachment-0001.html>