Review Request 125930: [lockscreen] Install cmake config for the LibKsld

Bhushan Shah bhush94 at gmail.com
Tue Nov 3 15:07:35 UTC 2015



> On Nov. 3, 2015, 8:28 p.m., Martin Klapetek wrote:
> > ksmserver/screenlocker/CMakeLists.txt, lines 125-133
> > <https://git.reviewboard.kde.org/r/125930/diff/3/?file=414574#file414574line125>
> >
> >     ...and I /think/ these two can be merged as well? I'm not entirely sure on the COMPONENT Devel though.

Can be merged but I prefer to not to... as both things are slightly different project.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125930/#review87927
-----------------------------------------------------------


On Nov. 3, 2015, 6:19 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125930/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 6:19 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Final patch before doing split in seperate repo.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/CMakeLists.txt a5f819b 
>   ksmserver/screenlocker/KScreenLockerConfig.cmake.in PRE-CREATION 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 73a340d 
>   ksmserver/screenlocker/ksldapp.h bc34820 
>   ksmserver/screenlocker/tests/CMakeLists.txt 2f8983b 
> 
> Diff: https://git.reviewboard.kde.org/r/125930/diff/
> 
> 
> Testing
> -------
> 
> builds, installs
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151103/8185b513/attachment.html>


More information about the Plasma-devel mailing list