Review Request 125930: [lockscreen] Install cmake config for the LibKsld

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125930/#review87927
-----------------------------------------------------------


Looks good, just couple improvement suggestions below.


ksmserver/screenlocker/CMakeLists.txt (lines 96 - 97)
<https://git.reviewboard.kde.org/r/125930/#comment60321>

    Imo this is quite randomly put in the middle of the KScreenLocker lib things, I think it was better at the bottom...though not that important.



ksmserver/screenlocker/CMakeLists.txt (lines 113 - 123)
<https://git.reviewboard.kde.org/r/125930/#comment60322>

    You can merge these two into a single install() command



ksmserver/screenlocker/CMakeLists.txt (lines 125 - 133)
<https://git.reviewboard.kde.org/r/125930/#comment60324>

    ...and I /think/ these two can be merged as well? I'm not entirely sure on the COMPONENT Devel though.


- Martin Klapetek


On Nov. 3, 2015, 1:49 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125930/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 1:49 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Final patch before doing split in seperate repo.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/CMakeLists.txt a5f819b 
>   ksmserver/screenlocker/KScreenLockerConfig.cmake.in PRE-CREATION 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 73a340d 
>   ksmserver/screenlocker/ksldapp.h bc34820 
>   ksmserver/screenlocker/tests/CMakeLists.txt 2f8983b 
> 
> Diff: https://git.reviewboard.kde.org/r/125930/diff/
> 
> 
> Testing
> -------
> 
> builds, installs
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151103/405f83a7/attachment-0001.html>