Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet
David Edmundson
david at davidedmundson.co.uk
Mon Nov 2 16:41:06 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125920/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 4:41 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 331a0e79036a44581eab78140593e18a6de6bba1 by David Edmundson to branch Plasma/5.4.
Repository: plasma-workspace
Description
-------
Uses the same approach as in 11483d2985c9b3c8314f2c6d8c8d7ed30a4ad0be
caching the value in a property
Diffs
-----
shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d
shell/scripting/panel.cpp bd78fc9b9dd95770126007777b2d41e3822e95ae
Diff: https://git.reviewboard.kde.org/r/125920/diff/
Testing
-------
edited my layout.js file
wiped config, restarted plasma
Gazed with awe as my panel was aligned in the middle
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/c87152a2/attachment.html>
More information about the Plasma-devel
mailing list