Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

Marco Martin notmart at gmail.com
Mon Nov 2 16:35:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125920/#review87881
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Nov. 2, 2015, 4:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125920/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 4:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Uses the same approach as in 11483d2985c9b3c8314f2c6d8c8d7ed30a4ad0be
> caching the value in a property
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
>   shell/scripting/panel.cpp bd78fc9b9dd95770126007777b2d41e3822e95ae 
> 
> Diff: https://git.reviewboard.kde.org/r/125920/diff/
> 
> 
> Testing
> -------
> 
> edited my layout.js file
> 
> wiped config, restarted plasma
> 
> Gazed with awe as my panel was aligned in the middle
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/4e98c722/attachment.html>


More information about the Plasma-devel mailing list