Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125913/#review87811
-----------------------------------------------------------


This isn't good enough because:
- The C++ code calculates per-line fade rects, not a single gradient (the label can be multi-line)
- It nixes the shadow
- It probably also breaks the bounding rect calc for the group dialog

All of these may be fixable to some degree; Text has a signal for line layouting that could factor into alpha mask calculation, there's the recent shader shadow work (https://paste.kde.org/pgjzwaltx/fesj84/raw) and the last one can be addressed with TextMetrics. All of this is on my todo, not very high up though.

- Eike Hein


On Nov. 1, 2015, 3:13 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125913/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 3:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346050
>     https://bugs.kde.org/show_bug.cgi?id=346050
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This removes the custom TextLabel and uses an OpacityMask to fade out the label.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/CMakeLists.txt 3c94cb7 
>   applets/taskmanager/package/contents/ui/Task.qml 9350481 
>   applets/taskmanager/plugin/taskmanagerplugin.cpp 1be1fed 
>   applets/taskmanager/plugin/textlabel.h f5f6de2 
>   applets/taskmanager/plugin/textlabel.cpp f916384 
> 
> Diff: https://git.reviewboard.kde.org/r/125913/diff/
> 
> 
> Testing
> -------
> 
> Label is faded out on regular entries and in popup when gets too wide. When gets too narrow label is properly hidden, launchers work fine, too. But there are probably many other usecases and scenarios I didn't know/test.
> 
> Also fixes task manager label with QT_DEVICE_PIXELRATIO > 1 (if we were to enable that)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151101/0fdd784e/attachment.html>