<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125913/">https://git.reviewboard.kde.org/r/125913/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This isn't good enough because:
- The C++ code calculates per-line fade rects, not a single gradient (the label can be multi-line)
- It nixes the shadow
- It probably also breaks the bounding rect calc for the group dialog</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All of these may be fixable to some degree; Text has a signal for line layouting that could factor into alpha mask calculation, there's the recent shader shadow work (https://paste.kde.org/pgjzwaltx/fesj84/raw) and the last one can be addressed with TextMetrics. All of this is on my todo, not very high up though.</p></pre>
<br />
<p>- Eike Hein</p>
<br />
<p>On November 1st, 2015, 3:13 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2015, 3:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346050">346050</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This removes the custom TextLabel and uses an OpacityMask to fade out the label.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Label is faded out on regular entries and in popup when gets too wide. When gets too narrow label is properly hidden, launchers work fine, too. But there are probably many other usecases and scenarios I didn't know/test.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also fixes task manager label with QT_DEVICE_PIXELRATIO > 1 (if we were to enable that)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/CMakeLists.txt <span style="color: grey">(3c94cb7)</span></li>
<li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: grey">(9350481)</span></li>
<li>applets/taskmanager/plugin/taskmanagerplugin.cpp <span style="color: grey">(1be1fed)</span></li>
<li>applets/taskmanager/plugin/textlabel.h <span style="color: grey">(f5f6de2)</span></li>
<li>applets/taskmanager/plugin/textlabel.cpp <span style="color: grey">(f916384)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125913/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>