Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

[Yoann Laissus]

> On mai 18, 2015, 8:46 matin, Martin Klapetek wrote:
> > Fwiw, I think it would be much better if the dataengine actually signalled the disk space change rather than polling, then the applet could just handle the incoming "changed" signals -> less polling around.

What mechanism do you think we can use to monitor disk space changes ? inotify/fanotify ?
I'm afraid that the load would be higher with that approach. (with network mounts, for instance)


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123817/#review80566
-----------------------------------------------------------


On mai 17, 2015, 11:01 matin, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123817/
> -----------------------------------------------------------
> 
> (Updated mai 17, 2015, 11:01 matin)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Previously, it was set to 0 so the space indicator was never refreshed.
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 
> 
> Diff: https://git.reviewboard.kde.org/r/123817/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150527/7e8f9d21/attachment.html>