Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

Martin Klapetek martin.klapetek at gmail.com
Mon May 18 08:46:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123817/#review80566
-----------------------------------------------------------


Fwiw, I think it would be much better if the dataengine actually signalled the disk space change rather than polling, then the applet could just handle the incoming "changed" signals -> less polling around.

- Martin Klapetek


On May 17, 2015, 1:01 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123817/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 1:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Previously, it was set to 0 so the space indicator was never refreshed.
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 
> 
> Diff: https://git.reviewboard.kde.org/r/123817/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150518/bf9266c2/attachment.html>


More information about the Plasma-devel mailing list