Review Request 123889: [krunner] Add button to clear history

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123889/#review80789
-----------------------------------------------------------

Ship it!


Please only ship this once the other patch is in.


kcms/runners/kcm.cpp (line 64)
<https://git.reviewboard.kde.org/r/123889/#comment55385>

    Please use `KConfigGroup::deleteEntry`


- Vishesh Handa


On May 23, 2015, 10:01 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123889/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 10:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Bugs: 275645?
>     https://bugs.kde.org/show_bug.cgi?id=275645?
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds a "Clear history" button to the plasmasearch kcm to clear the history.
> 
> 
> Diffs
> -----
> 
>   kcms/runners/kcm.cpp 10b7683 
> 
> Diff: https://git.reviewboard.kde.org/r/123889/diff/
> 
> 
> Testing
> -------
> 
> Clicked button, history gone, popup updated automatically. Could perhaps check whether the history is currently empty and be disabled in that case? Dunno if adding a file watcher to track live changes is worth it though.
> 
> 
> File Attachments
> ----------------
> 
> Button in KCM
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150525/036068ba/attachment.html>