Review Request 123889: [krunner] Add button to clear history
Kai Uwe Broulik
kde at privat.broulik.de
Sat May 23 22:01:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123889/
-----------------------------------------------------------
Review request for Plasma, KDE Usability and Vishesh Handa.
Bugs: 275645?
https://bugs.kde.org/show_bug.cgi?id=275645?
Repository: plasma-desktop
Description
-------
This adds a "Clear history" button to the plasmasearch kcm to clear the history.
Diffs
-----
kcms/runners/kcm.cpp 10b7683
Diff: https://git.reviewboard.kde.org/r/123889/diff/
Testing
-------
Clicked button, history gone, popup updated automatically. Could perhaps check whether the history is currently empty and be disabled in that case? Dunno if adding a file watcher to track live changes is worth it though.
File Attachments
----------------
Button in KCM
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150523/c4f77201/attachment.html>
More information about the Plasma-devel
mailing list