Review Request 123688: Improve sddm login experience

David Kahles david.kahles96 at gmail.com
Thu May 21 12:09:34 UTC 2015



> On May 8, 2015, 9:14 p.m., Kai Uwe Broulik wrote:
> > lookandfeel/contents/loginmanager/Main.qml, line 97
> > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line97>
> >
> >     Why would you put that into a property? Just tive the Timer an id
> 
> David Kahles wrote:
>     Yes, done.
>     Would you have time to explain the difference to me (e.g. next week)? I'm always struggling with this stuff and the qt.io wiki doesn't help :-/

Forget about it, I got the answer on my question.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123688/#review80101
-----------------------------------------------------------


On May 9, 2015, 2:46 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123688/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 2:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Disables the button and the passwordfield while the password check is
> running and hides the "Login Failed" message after 3 seconds.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 528f9b4e43ee6b8636ca1c816d5bad556bede871 
> 
> Diff: https://git.reviewboard.kde.org/r/123688/diff/
> 
> 
> Testing
> -------
> 
> Login and failed login are working as expected.
> Tested in qmlscene and on two computers running Archlinux.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150521/627b9d2b/attachment.html>


More information about the Plasma-devel mailing list