Review Request 123688: Improve sddm login experience
Kai Uwe Broulik
kde at privat.broulik.de
Fri May 8 19:16:51 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123688/#review80102
-----------------------------------------------------------
Sorry, hit the submit button too early
lookandfeel/contents/loginmanager/Main.qml (line 92)
<https://git.reviewboard.kde.org/r/123688/#comment54953>
The timer stops automatically because it's not repeating
lookandfeel/contents/loginmanager/Main.qml (lines 98 - 99)
<https://git.reviewboard.kde.org/r/123688/#comment54952>
Those are default
lookandfeel/contents/loginmanager/Main.qml (line 231)
<https://git.reviewboard.kde.org/r/123688/#comment54954>
I was wondering whether "sddm" just has a "busy" property that we could hook to the button's enabled property and have bindings do the magic rather than manual book keeping of the enabled state
- Kai Uwe Broulik
On Mai 8, 2015, 4:48 nachm., David Kahles wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123688/
> -----------------------------------------------------------
>
> (Updated Mai 8, 2015, 4:48 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Disables the button and the passwordfield while the password check is
> running and hides the "Login Failed" message after 3 seconds.
>
>
> Diffs
> -----
>
> lookandfeel/contents/loginmanager/Main.qml 528f9b4e43ee6b8636ca1c816d5bad556bede871
>
> Diff: https://git.reviewboard.kde.org/r/123688/diff/
>
>
> Testing
> -------
>
> Login and failed login are working as expected.
> Tested in qmlscene and on two computers running Archlinux.
>
>
> Thanks,
>
> David Kahles
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150508/bdc3ca5c/attachment.html>
More information about the Plasma-devel
mailing list