Review Request 123770: Play the login sound in its own thread

Martin Klapetek martin.klapetek at gmail.com
Thu May 14 18:03:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123770/
-----------------------------------------------------------

(Updated May 14, 2015, 6:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit b0fe26bfb314698693fcf011e59a28769bd9a437 by Martin Klapetek to branch master.


Repository: plasma-workspace


Description
-------

This feature was reverted back in the days as somehow it was blocking with PulseAudio startup which delayed the startup sequence quite considerably. This moves the sound playing into its own thread, which should prevent the blocking.


Diffs
-----

  ksmserver/startup.cpp 4155347 

Diff: https://git.reviewboard.kde.org/r/123770/diff/


Testing
-------

I was never able to reproduce the blocking, so I'm not sure if this actually fixes the problem.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150514/d44063ff/attachment.html>


More information about the Plasma-devel mailing list