Review Request 123770: Play the login sound in its own thread

Martin Klapetek martin.klapetek at gmail.com
Thu May 14 18:01:15 UTC 2015



> On May 13, 2015, 4:37 p.m., David Edmundson wrote:
> > Ship It!
> 
> Martin Klapetek wrote:
>     Stable?

I'll push to master for now, we can cherry pick afterwards.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123770/#review80304
-----------------------------------------------------------


On May 13, 2015, 12:09 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123770/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This feature was reverted back in the days as somehow it was blocking with PulseAudio startup which delayed the startup sequence quite considerably. This moves the sound playing into its own thread, which should prevent the blocking.
> 
> 
> Diffs
> -----
> 
>   ksmserver/startup.cpp 4155347 
> 
> Diff: https://git.reviewboard.kde.org/r/123770/diff/
> 
> 
> Testing
> -------
> 
> I was never able to reproduce the blocking, so I'm not sure if this actually fixes the problem.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150514/99a0afd7/attachment-0001.html>


More information about the Plasma-devel mailing list