Review Request 123547: Task manager : Make the middle click action on tasks configurable

[Yoann Laissus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/
-----------------------------------------------------------

(Updated mai 9, 2015, 4:16 après-midi)


Review request for Plasma.


Changes
-------

Updated with Eike's suggestions :
- Rename closeWindow(int winId) to closeByWinId(int winId)
- Rename closeGroup(int id) to closeByTaskId(int taskId)
- Rename the main label and the "Close" one in the configuration UI
- Rename CloseGroup to Close in the enum and in the configuration


Repository: plasma-desktop


Description
-------

Currently, only the shortcut Shift + Left click is available.
In KDE4, we had both.


Diffs (updated)
-----

  applets/taskmanager/package/contents/config/main.xml 7d3226d 
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml 72d4539 
  applets/taskmanager/package/contents/ui/Task.qml fcf7980 
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml a46ce36 
  applets/taskmanager/package/contents/ui/main.qml 49c612a 
  applets/taskmanager/plugin/backend.h ba2e453 
  applets/taskmanager/plugin/backend.cpp 68d8414 

Diff: https://git.reviewboard.kde.org/r/123547/diff/


Testing
-------

Tested with classic task manager and the icon only one.
Tested with all mouse button combinaisons and keyboard modifiers.


Thanks,

Yoann Laissus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150509/a022fdfe/attachment-0001.html>