Review Request 123547: Task manager : Make the middle click action on tasks configurable

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/#review80123
-----------------------------------------------------------



applets/taskmanager/package/contents/ui/ConfigGeneral.qml (line 98)
<https://git.reviewboard.kde.org/r/123547/#comment54967>

    Can you rename this to "On middle-click:"?



applets/taskmanager/package/contents/ui/ConfigGeneral.qml (line 104)
<https://git.reviewboard.kde.org/r/123547/#comment54968>

    Can you rename "Close Group" to "Close Window or Group"?



applets/taskmanager/package/contents/ui/main.qml (line 57)
<https://git.reviewboard.kde.org/r/123547/#comment54969>

    It's not a winId. Can you rename closeWindow and closeGroup to "closeByWinId" and "closeByItemId" everywhere? That's more literal.



applets/taskmanager/plugin/backend.h (line 53)
<https://git.reviewboard.kde.org/r/123547/#comment54970>

    Just "Close" is probably fine as the enum entry name and avoids the "It's not always a group" problem.


- Eike Hein


On May 8, 2015, 12:37 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123547/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 12:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently, only the shortcut Shift + Left click is available.
> In KDE4, we had both.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/config/main.xml 7d3226d 
>   applets/taskmanager/package/contents/ui/ConfigGeneral.qml 72d4539 
>   applets/taskmanager/package/contents/ui/Task.qml fcf7980 
>   applets/taskmanager/package/contents/ui/main.qml 49c612a 
>   applets/taskmanager/plugin/backend.h ba2e453 
>   applets/taskmanager/plugin/backend.cpp 68d8414 
> 
> Diff: https://git.reviewboard.kde.org/r/123547/diff/
> 
> 
> Testing
> -------
> 
> Tested with classic task manager and the icon only one.
> Tested with all mouse button combinaisons and keyboard modifiers.
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150509/aee0b039/attachment-0001.html>