Review Request 123684: Device notifier : Make the "Used space" progress bar clickable

Yoann Laissus yoann.laissus at gmail.com
Sat May 9 11:56:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123684/
-----------------------------------------------------------

(Updated mai 9, 2015, 11:56 matin)


Review request for Plasma.


Changes
-------

Create a new MouseArea in the ProgressBar item to redirect the click event to the top level MouseArea.


Repository: plasma-workspace


Description
-------

Currently, each device notifier items are clickable which opens the file manager or any associated apps.
In the item area, the only non clickable part is the used space progress bar, placed at the center.
It can be problematic as users tend to click on it because of its position.

Setting the enabled property of the ProgressBar to false will prevent click events to be stolen from the MouseArea.


Diffs (updated)
-----

  applets/devicenotifier/package/contents/ui/DeviceItem.qml 3078cef 

Diff: https://git.reviewboard.kde.org/r/123684/diff/


Testing
-------

Tested with mounted and umounted devices.


Thanks,

Yoann Laissus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150509/0ca49e6e/attachment-0001.html>


More information about the Plasma-devel mailing list