Review Request 123684: Device notifier : Make the "Used space" progress bar clickable

[Yoann Laissus]

> On mai 8, 2015, 7:20 après-midi, Kai Uwe Broulik wrote:
> > That would make the progress bar look disabled (gray rather than blue), giving the impression the entire item isn't interactive.
> > That's really an oversight in the QtQuick.ProgressBar that just has a MouseArea for the "hovered" property that cannot be disabled/accesse; clickable progress bars are quite rare.

I don't know why but the QML ProgressBar component isn't greyed out when disabled, maybe the Breeze theme ?
But I agree with you, making it disabled isn't the best way to achieve my goal.
I'll send a new patch to redirect the ProgressBar click event to the main MouseArea instead of disabling it.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123684/#review80104
-----------------------------------------------------------


On mai 8, 2015, 4:38 après-midi, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123684/
> -----------------------------------------------------------
> 
> (Updated mai 8, 2015, 4:38 après-midi)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently, each device notifier items are clickable which opens the file manager or any associated apps.
> In the item area, the only non clickable part is the used space progress bar, placed at the center.
> It can be problematic as users tend to click on it because of its position.
> 
> Setting the enabled property of the ProgressBar to false will prevent click events to be stolen from the MouseArea.
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 3078cef 
> 
> Diff: https://git.reviewboard.kde.org/r/123684/diff/
> 
> 
> Testing
> -------
> 
> Tested with mounted and umounted devices.
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150509/abfe0bea/attachment.html>