Review Request 122679: Show Desktop feature: refurbished
Thomas Lübking
thomas.luebking at gmail.com
Tue Mar 31 07:36:06 UTC 2015
> On März 30, 2015, 9:13 nachm., Kai Uwe Broulik wrote:
> > Really nice, I love the badbadwindows effect!
> >
> > Is it intended that the windows stay subtly visible a centimeter at the corner of the screen? Imho they should be either completely hidden or stick out further, and less transparent, potentially allowing to click them to exit the effect (don't know whether that's possible easily). The eyeonwindows enter animation is pretty neat actually but the exit animation seems to cause seizures ;)
> >
> > The only issue I've seen so far is when I minimize all windows, then open widget settings or containment settings, the dialog does not appear. When then exiting the badbadwindows effect, the window suddenly appears (probably wasn't registered by the effect) but my panel no longer flies in (should probably stay there anyway since eg. widget explorer still reserve space for it?) until I restart compositing.
> Is it intended that the windows stay subtly visible
Yupp. Hardcoded to 32px (what should probably be not ;-)
The idea was to "clearly" indicate the state (in contrast to just an empty desktop)
> stick out further, and less transparent
Since the purpose is to "show" the desktop, we'll require a good trade-off here. We must not (visually, they're not there, ie. receive no input) cover eg. TTFKAC ("The thing formerly known as cashew")
> allowing to click them to exit the effect
Not "easily", I'd rather not make this a fullscreen effect (like present windows) and hope to forward events to the desktop. One could however extend the active screen corners to
a) act on click
b) be "forcefully" stolen by effects (for that puropose only?)
to allow clicking a scren corner to exit the state.
> probably wasn't registered by the effect
Indeed, this is to be sorted out with final adjustments to the layer handling (the effects need to account for windows they should not manipulate - and panels should either stay or just be faded out, or moved to one direction only)
But you're right that windowAdded/Removed should be caught by the effect if we keep windows visible in the corners.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122679/#review78252
-----------------------------------------------------------
On März 30, 2015, 9:06 nachm., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122679/
> -----------------------------------------------------------
>
> (Updated März 30, 2015, 9:06 nachm.)
>
>
> Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.
>
>
> Bugs: 344083
> https://bugs.kde.org/show_bug.cgi?id=344083
>
>
> Repository: kwin
>
>
> Description
> -------
>
> commit b4e3a736c3643179b5b4ea73f7706918a03483fe
> Author: Thomas Lübking
> Date: Mon Mar 30 11:38:54 2015 +0200
>
> add eyeOnScreen effect
>
> commit 4aaeeda8fbebded0e915b39a54092c586de179ce
> Author: Thomas Lübking
> Date: Mon Mar 30 11:38:38 2015 +0200
>
> support gaussian curve and animationEnded signal in ScriptedEffect
>
>
> commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4
> Author: Thomas Lübking
> Date: Sun Mar 29 00:15:57 2015 +0100
>
> Add effect to move windows to corners on showing the desktop
> commit d92c46e96fe9fb13403b859c5e334b618d45d268
> Author: Thomas Lübking
> Date: Sun Mar 29 00:15:22 2015 +0100
>
> Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects
> commit ed38cf37b26aa15d77c5b73734581055be234233
> Author: Thomas Lübking
> Date: Sun Mar 29 00:13:41 2015 +0100
>
> make window elevation scriptable
> commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d
> Author: Thomas Lübking
> Date: Sun Mar 29 00:12:21 2015 +0100
>
> forward showingDesktop signal to effects
> commit 570a92331f3691c1fb2affa4f853c75d6062f7e3
> Author: Thomas Lübking
> Date: Sun Mar 29 00:08:32 2015 +0100
>
> emit signal when showingDesktop changes
>
>
> commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
> Author: Thomas Lübking
> Date: Sun Feb 22 16:41:45 2015 +0100
>
> add "MinimizeAll" script
>
> to compensate withdrawn core feature (which
> though has been hidden so far)
>
> commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
> Author: Thomas Lübking
> Date: Wed Feb 18 02:09:00 2015 +0100
>
> break showingDesktop w/ tabbox/PW/DG
>
> This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop.
> Also, it makes the tabbox more consistent.
>
> commit ff531c8e2adc407da00bef88f18d03e3829b25fa
> Author: Thomas Lübking
> Date: Wed Feb 18 01:37:45 2015 +0100
>
> implement showingDesktop by raising the desktop window
>
> commit 190a0cc022d9935d658a6218d0b3caa79b038563
> Author: Thomas Lübking
> Date: Wed Feb 18 00:09:46 2015 +0100
>
> remove secret showDesktopIsMinimizeAll feature
>
>
> Diffs
> -----
>
> client.h 6b947fe
> client.cpp b6af2fa
> effects.h ae71d61
> effects.cpp 20a8773
> effects/CMakeLists.txt 98a9349
> effects/badbadwindows/CMakeLists.txt PRE-CREATION
> effects/badbadwindows/package/CMakeLists.txt PRE-CREATION
> effects/badbadwindows/package/contents/code/main.js PRE-CREATION
> effects/badbadwindows/package/metadata.desktop PRE-CREATION
> effects/desktopgrid/desktopgrid.cpp 97cb2a3
> effects/eyeonscreen/CMakeLists.txt PRE-CREATION
> effects/eyeonscreen/package/CMakeLists.txt PRE-CREATION
> effects/eyeonscreen/package/contents/code/main.js PRE-CREATION
> effects/eyeonscreen/package/metadata.desktop PRE-CREATION
> effects/presentwindows/presentwindows.cpp 7a62ec0
> kwin.kcfg 80ca365
> layers.cpp ae08207
> libkwineffects/kwineffects.h b77e461
> manage.cpp 8b1a2ee
> options.h 67e5868
> options.cpp cdaa851
> scripting/scriptedeffect.h 39af241
> scripting/scriptedeffect.cpp ba646f6
> scripts/CMakeLists.txt 34dedb7
> scripts/minimizeall/contents/code/main.js PRE-CREATION
> scripts/minimizeall/metadata.desktop PRE-CREATION
> tabbox/tabbox.cpp 4a00e4b
> workspace.h 16fa351
> workspace.cpp f9c1ab1
>
> Diff: https://git.reviewboard.kde.org/r/122679/diff/
>
>
> Testing
> -------
>
> * The script (though mostly in KWin4, trouble w/ ksycoca5...)
> * Obviously the supersecret key is now dead ;-)
> * Been playing around with alternate desktop showing.
>
>
> Thanks,
>
> Thomas Lübking
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150331/f0a772e3/attachment-0001.html>
More information about the Plasma-devel
mailing list