Review Request 123147: do not install so link if the headers are not being installed

Harald Sitter sitter at kde.org
Mon Mar 30 10:28:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123147/
-----------------------------------------------------------

(Updated March 30, 2015, 10:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit e1b142a8970d44090592a7573c55f6b4e76995c9 by Harald Sitter to branch master.


Repository: plasma-desktop


Description
-------

in the no-install-header mode it keeps the library entirely private by
not installing the symlink, whereas when installing the headers the so
link is also being installed.


Diffs
-----

  lib/kactivities-stats/src/lib/stats/CMakeLists.txt f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e 

Diff: https://git.reviewboard.kde.org/r/123147/diff/


Testing
-------

make -j9; make install DESTDIR=. --> doesn't install .so

change experimental header install variable to true --> installs .so


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150330/b8976df5/attachment-0001.html>


More information about the Plasma-devel mailing list