Review Request 123147: do not install so link if the headers are not being installed

David Edmundson david at davidedmundson.co.uk
Mon Mar 30 10:21:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123147/#review78210
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 27, 2015, 8:31 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123147/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 8:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> in the no-install-header mode it keeps the library entirely private by
> not installing the symlink, whereas when installing the headers the so
> link is also being installed.
> 
> 
> Diffs
> -----
> 
>   lib/kactivities-stats/src/lib/stats/CMakeLists.txt f58aa5d9bd200b3c037a5e7e5a7ad893bbae956e 
> 
> Diff: https://git.reviewboard.kde.org/r/123147/diff/
> 
> 
> Testing
> -------
> 
> make -j9; make install DESTDIR=. --> doesn't install .so
> 
> change experimental header install variable to true --> installs .so
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150330/ef3e851e/attachment.html>


More information about the Plasma-devel mailing list