Review Request 123171: Fix opening ksysguarddrc config file

David Edmundson david at davidedmundson.co.uk
Sun Mar 29 11:58:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123171/#review78163
-----------------------------------------------------------



ksysguardd/CMakeLists.txt (line 6)
<https://git.reviewboard.kde.org/r/123171/#comment53543>

    from what I understand of the ECM docs, this is a deprecated variable
    
    and we should use
    KDE_INSTALL_FULL_SYSCONFDIR instead
    
    which will also fix the problem.


- David Edmundson


On March 29, 2015, 11:47 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123171/
> -----------------------------------------------------------
> 
> (Updated March 29, 2015, 11:47 a.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> This fixes -DKSYSGUARDDRCFILE definition so that there are no extra quotes.
> It also fixes issue with using non-default install prefix (eg. when CMAKE_INSTALL_PREFIX is not /usr and thus SYSCONF_INSTALL_DIR is relative and not /etc)
> 
> 
> Diffs
> -----
> 
>   ksysguardd/CMakeLists.txt 6bd8679 
> 
> Diff: https://git.reviewboard.kde.org/r/123171/diff/
> 
> 
> Testing
> -------
> 
> No error in syslog after applying this patch: cannot open config file '"etc/ksysguarddrc"'
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150329/81898abd/attachment.html>


More information about the Plasma-devel mailing list