Review Request 123106: Layout children in TabBarLayout right away

Kai Uwe Broulik kde at privat.broulik.de
Wed Mar 25 17:20:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123106/
-----------------------------------------------------------

(Updated March 25, 2015, 5:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit b7e4669db2f4ef5366f4dc5baee38bb809aaa5c7 by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

When Component.onCompleted is fired all the static children have been initialized thus we can call the layout function right away.
OnChildrenChanged is fired like 20 times afterwards for some reason (the number of children doesn't change) compressed by the Timer.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml fd9f532 

Diff: https://git.reviewboard.kde.org/r/123106/diff/


Testing
-------

Improves Kickoff's first appearance, the tabs no longer stick to the top left corner (top panel) for a couple of frames.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/2db70dbb/attachment.html>


More information about the Plasma-devel mailing list