Review Request 123106: Layout children in TabBarLayout right away

David Edmundson david at davidedmundson.co.uk
Wed Mar 25 13:33:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123106/#review78038
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On March 22, 2015, 8:13 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123106/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 8:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When Component.onCompleted is fired all the static children have been initialized thus we can call the layout function right away.
> OnChildrenChanged is fired like 20 times afterwards for some reason (the number of children doesn't change) compressed by the Timer.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml fd9f532 
> 
> Diff: https://git.reviewboard.kde.org/r/123106/diff/
> 
> 
> Testing
> -------
> 
> Improves Kickoff's first appearance, the tabs no longer stick to the top left corner (top panel) for a couple of frames.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150325/ddb3c5c4/attachment.html>


More information about the Plasma-devel mailing list