Review Request 123119: Add a component file that mimicks KTitleWidget

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 24 17:54:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123119/#review78013
-----------------------------------------------------------



src/qmlcontrols/kquickcontrols/Title.qml (line 32)
<https://git.reviewboard.kde.org/r/123119/#comment53461>

    You can also change KTextWidget so that they both get the font size properly from QFontDatabase::systemFont(QFontDatabase::TitleFont).
    
    Then we fix the QPT value in frameworksintegration if needed.


- Aleix Pol Gonzalez


On March 24, 2015, 4:25 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123119/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 4:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This will stick to the app's QtQuickControls theme.
> 
> This is needed as otherwise people put PlasmaHeadings in apps which
> otherwise follow the QStyle which is going to look really inconsistent.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/Title.qml PRE-CREATION 
>   tests/titletest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150324/a1b47f12/attachment-0001.html>


More information about the Plasma-devel mailing list