Review Request 123119: Add a component file that mimicks KTitleWidget

David Edmundson david at davidedmundson.co.uk
Tue Mar 24 16:51:21 UTC 2015



> On March 24, 2015, 4:17 p.m., Kai Uwe Broulik wrote:
> > KTitleWidget also has a subtitle, no?
> > 
> > Also pity that we cannot have that stuff styled since KTitleWidget has a border usually but just in our styles does not.

hmm, I could try and push for a frame in QQC

I'll add the comment.


> On March 24, 2015, 4:17 p.m., Kai Uwe Broulik wrote:
> > src/qmlcontrols/kquickcontrols/Title.qml, line 32
> > <https://git.reviewboard.kde.org/r/123119/diff/1/?file=356485#file356485line32>
> >
> >     This breaks when the user changes his font size

I can: 
have a qobject that monitors the font in kquickcontrolsaddons.private
have another Text{} object in here that's hidden.

both kinda suck, any better ideas?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123119/#review78004
-----------------------------------------------------------


On March 24, 2015, 3:25 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123119/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This will stick to the app's QtQuickControls theme.
> 
> This is needed as otherwise people put PlasmaHeadings in apps which
> otherwise follow the QStyle which is going to look really inconsistent.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/Title.qml PRE-CREATION 
>   tests/titletest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150324/18409df0/attachment.html>


More information about the Plasma-devel mailing list