Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs

David Rosca nowrep at gmail.com
Thu Mar 12 20:40:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122920/
-----------------------------------------------------------

(Updated March 12, 2015, 8:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 69fb206e395a9795648bd3e4ba28898f1c042c99 by David Rosca to branch Plasma/5.2.


Repository: plasma-workspace


Description
-------

Don't show pause button for jobs that are not suspendable. Clicking on the pause button for non-suspendable jobs has no effect anyway.

This patch also applies same logic for stop (kill) button.


Diffs
-----

  applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab 

Diff: https://git.reviewboard.kde.org/r/122920/diff/


Testing
-------

Non-suspendable jobs no longer have pause button in notifications.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/a8b2996a/attachment.html>


More information about the Plasma-devel mailing list