Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122920/#review77398
-----------------------------------------------------------

Ship it!



applets/notifications/package/contents/ui/JobDelegate.qml
<https://git.reviewboard.kde.org/r/122920/#comment53150>

    You can just do
    visible: getData(jobsSource.data, "suspendable", 0)


- Kai Uwe Broulik


On März 12, 2015, 4:06 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122920/
> -----------------------------------------------------------
> 
> (Updated März 12, 2015, 4:06 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Don't show pause button for jobs that are not suspendable. Clicking on the pause button for non-suspendable jobs has no effect anyway.
> 
> This patch also applies same logic for stop (kill) button.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122920/diff/
> 
> 
> Testing
> -------
> 
> Non-suspendable jobs no longer have pause button in notifications.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/3e6e3b1a/attachment.html>