Review Request 122886: QML-only KCM base

Marco Martin notmart at gmail.com
Thu Mar 12 16:10:59 UTC 2015



> On March 10, 2015, 11:30 a.m., Marco Martin wrote:
> > src/quickaddons/configmodule.h, line 43
> > <https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line43>
> >
> >     I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but unfortunately that name is terrible, since makes people think this arrives from Qt (should have been called KQuickAddons, all old classes in it namespaced etc, that library is a disaster :/))

I'm almost tempted to re-export everything under KQuickAddons both library and namespace, deprecating completely QuickAddons (ConfigModule class would be only in kquickaddons, not the old one)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77247
-----------------------------------------------------------


On March 12, 2015, 2:55 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150312/56d7a49f/attachment.html>


More information about the Plasma-devel mailing list