Review Request 122886: QML-only KCM base
Marco Martin
notmart at gmail.com
Tue Mar 10 11:30:45 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77247
-----------------------------------------------------------
src/quickaddons/configmodule.h
<https://git.reviewboard.kde.org/r/122886/#comment53046>
I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but unfortunately that name is terrible, since makes people think this arrives from Qt (should have been called KQuickAddons, all old classes in it namespaced etc, that library is a disaster :/))
- Marco Martin
On March 10, 2015, 11:28 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 11:28 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
> They will be loaded in systemsettings by review 122887
>
>
> Diffs
> -----
>
> src/quickaddons/CMakeLists.txt 3c7a34b
> src/quickaddons/configmodule.h PRE-CREATION
> src/quickaddons/configmodule.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150310/99ece408/attachment.html>
More information about the Plasma-devel
mailing list