Review Request 122886: QML-only KCM base

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
-----------------------------------------------------------



src/quickaddons/configmodule.h
<https://git.reviewboard.kde.org/r/122886/#comment53086>

    this should mention packages somewhere.



src/quickaddons/configmodule.h
<https://git.reviewboard.kde.org/r/122886/#comment53084>

    This documentation tells me nothing, and I'm not sure what this does from the method name.



src/quickaddons/configmodule.h
<https://git.reviewboard.kde.org/r/122886/#comment53083>

    I guess you copy and pasted all these.
    KConfigXT isn't relevant at all here.



src/quickaddons/configmodule.cpp
<https://git.reviewboard.kde.org/r/122886/#comment53085>

    when combined with your other KCModule patch you have a crash.
    
    From KCModule docs:
    This sets the KAboutData returned by aboutData() The about data is now owned by KCModule.
    
    So this will result in a double delete.
    Same for the delete in setAboutData.


- David Edmundson


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150311/a1a05377/attachment.html>