Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 10, 2015, 11:33 a.m., Marco Martin wrote:
> > src/quickaddons/configmodule.cpp, line 167
> > <https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line167>
> >
> >     I didn't test things that need authentication yet (if some good soul ports a module that uses it would be great)
> >     but seems there may be a problem here due to KAuth assuming QWidgets

This is for a custom KDE extension to polkit setWIdForAction that tells the KDE polkit agent which window is about to trigger an action so that the window manager can do something sensible wrt to focus. So it's not super criticial.

It's also fixable, KAuth only uses it for a window ID, so we can add a QWindow/

Right now it's not a problem, as when used via KCModuleQml, it will call KCModule::setAuthAction which changes the parent widget anyway.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77248
-----------------------------------------------------------


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150311/8c07136b/attachment-0001.html>