Review Request 124072: Refactor the Calendar grid computation a bit

Martin Klapetek martin.klapetek at gmail.com
Mon Jun 15 14:35:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124072/
-----------------------------------------------------------

(Updated June 15, 2015, 2:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 23add5d6e4c19d353b7d8bdaf9ea2f126e7f30b9 by Martin Klapetek to branch master.


Repository: plasma-framework


Description
-------

Makes the code a bit simpler & lighter and fixes the sometimes missing bottom line in calendar.

The grid is now equally padded from both sides (including the month name), so basically it's now
always aligned to the center and this also fixes the cases where there was a bigger padding on
one side than on the other.

The grid is now also anchored to the bottom so that the bottom margin can stay moreless consistent
with the side margins in different sizes.


Diffs
-----

  src/declarativeimports/calendar/qml/DaysCalendar.qml 5308708 
  src/declarativeimports/calendar/qml/MonthView.qml 86e37d8 

Diff: https://git.reviewboard.kde.org/r/124072/diff/


Testing
-------

Lots of 600x-zoom inspections and pixel counting. Tested both in Calendar applet and Digital Clock applet.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150615/ee0a38c3/attachment.html>


More information about the Plasma-devel mailing list