Review Request 124053: [protocols] Reduce plasma-shell to the bare minimum what we need right now

Marco Martin notmart at gmail.com
Tue Jun 9 18:55:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124053/#review81345
-----------------------------------------------------------


+1

- Marco Martin


On June 9, 2015, 6:50 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124053/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 6:50 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> We only want to be able to set positions and set window type.
> 
> [protocols] Reduce roles in plasma-shell to bare minimum plasma needs
> 
> The enum values follow the values uses in NET::WindowType of
> KWindowSystem framework.
> 
> [client] Add binding for PlasmaShell and PlasmaShellSurface
> 
> 
> [server] Add bindings for PlasmaShell interface
> 
> 
> [tests] Add a test application for PlasmaShellInterface
> 
> Creates a panel.
> 
> 
> Diffs
> -----
> 
>   src/client/CMakeLists.txt ab592b20dde878365df8374ea9a43dbf2f10cb59 
>   src/client/plasmashell.h PRE-CREATION 
>   src/client/plasmashell.cpp PRE-CREATION 
>   src/client/protocols/plasma-shell.xml e555df265acaa24de9261bb5b2fd20a9e5437c64 
>   src/client/registry.h 52ef84382fe44951f2e512217c06e7110403e8db 
>   src/client/registry.cpp fe2dbed4e594037f65ce5ec629012800e0d5e9eb 
>   src/server/CMakeLists.txt 466363466f8dcde490fc7d724d486e68093111d7 
>   src/server/display.h 74865992dff816622021e49f1b5a9791c7505163 
>   src/server/display.cpp 1796f53f9e70e3fbd6fc8645d8b897c1500544e9 
>   src/server/plasmashell_interface.h PRE-CREATION 
>   src/server/plasmashell_interface.cpp PRE-CREATION 
>   tests/CMakeLists.txt c41b7a3a5a7a078b1fbaa2a3cb0cd90cdd6e7b53 
>   tests/paneltest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124053/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150609/9f427479/attachment.html>


More information about the Plasma-devel mailing list