<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124053/">https://git.reviewboard.kde.org/r/124053/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On June 9th, 2015, 6:50 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 9, 2015, 6:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We only want to be able to set positions and set window type.
[protocols] Reduce roles in plasma-shell to bare minimum plasma needs
The enum values follow the values uses in NET::WindowType of
KWindowSystem framework.
[client] Add binding for PlasmaShell and PlasmaShellSurface
[server] Add bindings for PlasmaShell interface
[tests] Add a test application for PlasmaShellInterface
Creates a panel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/client/CMakeLists.txt <span style="color: grey">(ab592b20dde878365df8374ea9a43dbf2f10cb59)</span></li>
<li>src/client/plasmashell.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/plasmashell.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/protocols/plasma-shell.xml <span style="color: grey">(e555df265acaa24de9261bb5b2fd20a9e5437c64)</span></li>
<li>src/client/registry.h <span style="color: grey">(52ef84382fe44951f2e512217c06e7110403e8db)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(fe2dbed4e594037f65ce5ec629012800e0d5e9eb)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(466363466f8dcde490fc7d724d486e68093111d7)</span></li>
<li>src/server/display.h <span style="color: grey">(74865992dff816622021e49f1b5a9791c7505163)</span></li>
<li>src/server/display.cpp <span style="color: grey">(1796f53f9e70e3fbd6fc8645d8b897c1500544e9)</span></li>
<li>src/server/plasmashell_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/plasmashell_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(c41b7a3a5a7a078b1fbaa2a3cb0cd90cdd6e7b53)</span></li>
<li>tests/paneltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>