Review Request 124039: Bind translucent theme to background contrast rather than blur effect

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124039/
-----------------------------------------------------------

(Updated June 8, 2015, 3:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit d65c0ed1d07b4fb09643c9401a6697db1282d89e by Kai Uwe Broulik to branch master.


Bugs: 342934 and 348154
    http://bugs.kde.org/show_bug.cgi?id=342934
    http://bugs.kde.org/show_bug.cgi?id=348154


Repository: plasma-framework


Description
-------

Only the background contrast provides real contrast for the background, the blur doesn't improve readability that much, so when background contrast is disabled we use the less transparent svgs instead. This makes the panels look similarly white (so no more embarrasing reviews on news websites) to the regular theme and significantly improves readability.


Diffs
-----

  src/plasma/private/theme_p.h 68336f0 
  src/plasma/private/theme_p.cpp f64265b 

Diff: https://git.reviewboard.kde.org/r/124039/diff/


Testing
-------

Blur: off, Contrast: off -> opaque
Blur: on,  Contrast: off -> opaque (previously transparent)
Blur: off, Contrast: on  -> transparent, good readability (previously opaque)
Blur: on,  Contrast: on  -> transparent, good readability

The regular SVG could become slightly transparent though, it looks like the "opaque" variant that is used when compositing is disabled.

With Breeze Dark transparency without contrast isn't that strong but still readability is significantly improved.


File Attachments
----------------

Contrast enabled
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/a2f7a225-b0f9-4e91-ac42-5d58cd4318f6__backgroundcontraston.png
Contrast off (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/9e6b0d51-f58a-483e-bbf5-fee942739f44__backgroundcontrastoffbefore.png
Contrast off (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/5c609063-bbfc-4d8d-b4dd-220154523415__backgroundcontrastoffafter.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150608/2416f6f1/attachment.html>