Review Request 124005: Add week numbers to calendar - Part 2

[Sebastian Kügler]

> On June 4, 2015, 9:59 a.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/config/main.xml, line 43
> > <https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43>
> >
> >     Why not make it default?
> >     
> >     Yours looks much more beautiful and tidy than the old 4.x version which always confused me.
> 
> Martin Klapetek wrote:
>     "Simple by default, powerful when needed" ;) It's not a feature everyone wants/needs, but it's there when they do.

IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional.

It's not "powerful when needed", it's "powerful when the user happens to find the option in the config dialog" this way, it's advertised nowhere that this feature is now available.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124005/#review81163
-----------------------------------------------------------


On June 4, 2015, 9:55 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124005/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> One of the most requested features for Plasma5. This is the applet's part (basically just the config).
> 
> See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot.
> 
> Another part will be the (standalone) Calendar applet.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 5237160 
>   applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 
> 
> Diff: https://git.reviewboard.kde.org/r/124005/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/00fbe268/attachment-0001.html>