Review Request 124005: Add week numbers to calendar - Part 2

[Martin Klapetek]

> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/config/main.xml, line 43
> > <https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43>
> >
> >     Why not make it default?
> >     
> >     Yours looks much more beautiful and tidy than the old 4.x version which always confused me.

"Simple by default, powerful when needed" ;) It's not a feature everyone wants/needs, but it's there when they do.


> On June 4, 2015, 11:59 a.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/ui/configAppearance.qml, line 75
> > <https://git.reviewboard.kde.org/r/124005/diff/1/?file=378758#file378758line75>
> >
> >     "Show week numbers in calendar" ?

Ok.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124005/#review81163
-----------------------------------------------------------


On June 4, 2015, 11:55 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124005/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:55 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> One of the most requested features for Plasma5. This is the applet's part (basically just the config).
> 
> See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot.
> 
> Another part will be the (standalone) Calendar applet.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 5237160 
>   applets/digital-clock/package/contents/ui/CalendarView.qml b5a080b 
>   applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 
> 
> Diff: https://git.reviewboard.kde.org/r/124005/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/b22404b2/attachment.html>